--===============3663562189936320942== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/5072/#review7145 ----------------------------------------------------------- Ship it! Looks good, thanks. Just missing documentation for the enum values, and it'= s good to go ;) - David On 2010-08-19 15:48:48, George Kiagiadakis wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/5072/ > ----------------------------------------------------------- > = > (Updated 2010-08-19 15:48:48) > = > = > Review request for kdelibs, David Faure and Oswald Buddenhagen. > = > = > Summary > ------- > = > This patch modifies KGlobalConfig so that it is possible for applications= to tell it not to connect to dbus and listen for configuration changes fro= m other applications. This is useful for kdm, because if QDBusConnection::s= essionBus() is called while there is no session bus running, a new session = bus is automatically created, which makes no sense for kdm. > = > = > Diffs > ----- > = > trunk/KDE/kdelibs/kdeui/kernel/kglobalsettings.h 1165324 = > trunk/KDE/kdelibs/kdeui/kernel/kglobalsettings.cpp 1165324 = > = > Diff: http://reviewboard.kde.org/r/5072/diff > = > = > Testing > ------- > = > Tested with kdm after modifying its call to activate() to use the DontLis= tenForChanges flag. kdm no longer starts a dbus session. > = > = > Thanks, > = > George > = > --===============3663562189936320942== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde= .org/r/5072/

Ship it!

Looks good=
, thanks. Just missing documentation for the enum values, and it's good=
 to go ;)

- David


On August 19th, 2010, 3:48 p.m., George Kiagiadakis wrote:

Review request for kdelibs, David Faure and Oswald Buddenhagen.
By George Kiagiadakis.

Updated 2010-08-19 15:48:48

Descripti= on 

This patch modifies KGlobalConfig so that it is possible for=
 applications to tell it not to connect to dbus and listen for configuratio=
n changes from other applications. This is useful for kdm, because if QDBus=
Connection::sessionBus() is called while there is no session bus running, a=
 new session bus is automatically created, which makes no sense for kdm.

Testing <= /h1> 
Tested with kdm after modifying its call to activate() to us=
e the DontListenForChanges flag. kdm no longer starts a dbus session.

Diffs=

  • trunk/KDE/kdelibs/kdeui/kernel/kglobalsettings.h (1165324)
  • trunk/KDE/kdelibs/kdeui/kernel/kglobalsettings.cpp (1165324)

View Diff
--===============3663562189936320942==--