[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: fixed file kioslave on windows (it was reporting
From:       Milian Wolff <mail () milianw ! de>
Date:       2010-07-13 10:07:44
Message-ID: 201007131207.44549.mail () milianw ! de
[Download RAW message or body]


On Tuesday, 13. July 2010 09:59:28 David Faure wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3938/#review6521
> -----------------------------------------------------------
> 
> Ship it!
> 
> 
> Sounds good to me, I am very much in favor of using the same code on all
> platforms ;)

Note: Apparently KIO::stat was/is broken on windows as well, see:

https://bugs.kde.org/show_bug.cgi?id=243718

Does this patch fixes that?

Bye

> On 2010-05-10 18:38:48, Ilie Halip wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.kde.org/r/3938/
> > -----------------------------------------------------------
> > 
> > (Updated 2010-05-10 18:38:48)
> > 
> > 
> > Review request for kdelibs, George Kiagiadakis and Patrick Spendrin.
> > 
> > 
> > Summary
> > -------
> > 
> > This patch fixes the problem reported here:
> > https://bugs.kde.org/show_bug.cgi?id=207162
> > 
> > It was a problem that I think happened all over KDE on Windows, because
> > the kio_file slave was reporting incorrect information (S_IFREG for
> > non-existing files). I removed the createUDSEntryWin function, and moved
> > FileProtocol::stat inside file.cpp, because both unix and win now have a
> > common implementation.
> > 
> > 
> > This addresses bug 207162.
> > 
> >     https://bugs.kde.org/show_bug.cgi?id=207162
> > 
> > Diffs
> > -----
> > 
> >   trunk/KDE/kdelibs/kioslave/file/file.cpp 1124299
> >   trunk/KDE/kdelibs/kioslave/file/file_unix.cpp 1124299
> >   trunk/KDE/kdelibs/kioslave/file/file_win.cpp 1124299
> > 
> > Diff: http://reviewboard.kde.org/r/3938/diff
> > 
> > 
> > Testing
> > -------
> > 
> > listing files in directories
> > saving/loading files from ktuberling with/without extension
> > 
> > 
> > Thanks,
> > 
> > Ilie

-- 
Milian Wolff
mail@milianw.de
http://milianw.de

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]