From kde-core-devel  Tue Jul 13 10:07:44 2010
From: Milian Wolff <mail () milianw ! de>
Date: Tue, 13 Jul 2010 10:07:44 +0000
To: kde-core-devel
Subject: Re: Review Request: fixed file kioslave on windows (it was reporting
Message-Id: <201007131207.44549.mail () milianw ! de>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=127901571024162
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--nextPart3081844.eKeaaYoQRu"

--nextPart3081844.eKeaaYoQRu
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

On Tuesday, 13. July 2010 09:59:28 David Faure wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3938/#review6521
> -----------------------------------------------------------
>=20
> Ship it!
>=20
>=20
> Sounds good to me, I am very much in favor of using the same code on all
> platforms ;)

Note: Apparently KIO::stat was/is broken on windows as well, see:

https://bugs.kde.org/show_bug.cgi?id=3D243718

Does this patch fixes that?

Bye

> On 2010-05-10 18:38:48, Ilie Halip wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.kde.org/r/3938/
> > -----------------------------------------------------------
> >=20
> > (Updated 2010-05-10 18:38:48)
> >=20
> >=20
> > Review request for kdelibs, George Kiagiadakis and Patrick Spendrin.
> >=20
> >=20
> > Summary
> > -------
> >=20
> > This patch fixes the problem reported here:
> > https://bugs.kde.org/show_bug.cgi?id=3D207162
> >=20
> > It was a problem that I think happened all over KDE on Windows, because
> > the kio_file slave was reporting incorrect information (S_IFREG for
> > non-existing files). I removed the createUDSEntryWin function, and moved
> > FileProtocol::stat inside file.cpp, because both unix and win now have a
> > common implementation.
> >=20
> >=20
> > This addresses bug 207162.
> >=20
> >     https://bugs.kde.org/show_bug.cgi?id=3D207162
> >=20
> > Diffs
> > -----
> >=20
> >   trunk/KDE/kdelibs/kioslave/file/file.cpp 1124299
> >   trunk/KDE/kdelibs/kioslave/file/file_unix.cpp 1124299
> >   trunk/KDE/kdelibs/kioslave/file/file_win.cpp 1124299
> >=20
> > Diff: http://reviewboard.kde.org/r/3938/diff
> >=20
> >=20
> > Testing
> > -------
> >=20
> > listing files in directories
> > saving/loading files from ktuberling with/without extension
> >=20
> >=20
> > Thanks,
> >=20
> > Ilie

=2D-=20
Milian Wolff
mail@milianw.de
http://milianw.de

--nextPart3081844.eKeaaYoQRu
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEABECAAYFAkw8OvAACgkQDA6yEs0dE5MPMQCfXAP7T0o05V3g1M5iXjuLCzTM
83QAoLZFbKqwQXmJT4z0g5hyWiBb8B/A
=3gXG
-----END PGP SIGNATURE-----

--nextPart3081844.eKeaaYoQRu--