[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Do not fallback to Hicolor when Oxygen provides a
From: "Riccardo Iaconelli" <riccardo () kde ! org>
Date: 2010-06-20 19:13:16
Message-ID: 20100620191316.24585.39234 () localhost
[Download RAW message or body]
> On 2010-06-20 18:39:13, Michael Pyne wrote:
> > I'll not that KIconLoader is not "incorrect" in that the icon-theme-spe=
c does specify that hicolor should be searched if the desired icon does not=
exist in a theme. shared-mime-info kind of overrides that by saying that i=
f no specific icon is located, to search for a generic fallback icon, but t=
hat should only be mime icons.
> > =
> > One question is what do we do if hicolor happens to have an exact match=
of the required size, do we accept hicolor or try to fallback to generic? =
I would say accept hicolor's more specific video-mp4 in preference to video=
-x-generic, but that could look ugly in several themes.
As an artist, I'd say ship it. If the name spec says something different, I=
think we should change it.
I've not reviewed this patch code-wise though.
For the second problem of yours, but still as an artistic advice, I'd say i=
t's better to load the generic mime icon over accepting hicolor's specific =
version.
- Riccardo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4403/#review6198
-----------------------------------------------------------
On 2010-06-20 09:18:37, Aur=C3=A9lien G=C3=A2teau wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4403/
> -----------------------------------------------------------
> =
> (Updated 2010-06-20 09:18:37)
> =
> =
> Review request for kdelibs and Rafael Fern=C3=A1ndez L=C3=B3pez.
> =
> =
> Summary
> -------
> =
> When loading an icon for video-mp4, KIconLoader incorrectly returns "vide=
o.png" from Hicolor, instead of returning "video-x-generic.png" from Oxygen=
. Since Hicolor only has a 16x16 version, this results in blurry icons in D=
olphin or Gwenview when icons are bigger than 16x16.
> =
> This is because the current code fallbacks to Hicolor before looking for =
a "-x-generic" version.
> =
> =
> Diffs
> -----
> =
> trunk/KDE/kdelibs/kdeui/icons/kiconloader.cpp 1140302 =
> trunk/KDE/kdelibs/kdeui/tests/kiconloader_unittest.cpp 1140302 =
> =
> Diff: http://reviewboard.kde.org/r/4403/diff
> =
> =
> Testing
> -------
> =
> - Added a unit-test entry to check we get video-x-generic.
> - Icons are no longer blurry after the patch.
> =
> =
> Thanks,
> =
> Aur=C3=A9lien
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4403/">http://reviewboard.kde.org/r/4403/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 20th, 2010, 6:39 p.m., <b>Michael Pyne</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre>I'll not that KIconLoader is not \
"incorrect" in that the icon-theme-spec does specify that hicolor should be \
searched if the desired icon does not exist in a theme. shared-mime-info kind of \
overrides that by saying that if no specific icon is located, to search for a generic \
fallback icon, but that should only be mime icons.
One question is what do we do if hicolor happens to have an exact match of the \
required size, do we accept hicolor or try to fallback to generic? I would say accept \
hicolor's more specific video-mp4 in preference to video-x-generic, but that \
could look ugly in several themes.</pre> </blockquote>
</blockquote>
<pre>As an artist, I'd say ship it. If the name spec says something different, I \
think we should change it. I've not reviewed this patch code-wise though.
For the second problem of yours, but still as an artistic advice, I'd say \
it's better to load the generic mime icon over accepting hicolor's specific \
version.</pre> <br />
<p>- Riccardo</p>
<br />
<p>On June 20th, 2010, 9:18 a.m., Aurélien Gâteau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and Rafael Fernández López.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated 2010-06-20 09:18:37</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">When loading an icon for video-mp4, \
KIconLoader incorrectly returns "video.png" from Hicolor, instead of \
returning "video-x-generic.png" from Oxygen. Since Hicolor only has a 16x16 \
version, this results in blurry icons in Dolphin or Gwenview when icons are bigger \
than 16x16.
This is because the current code fallbacks to Hicolor before looking for a \
"-x-generic" version.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">- Added a unit-test entry to check we get \
video-x-generic.
- Icons are no longer blurry after the patch.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdelibs/kdeui/icons/kiconloader.cpp <span style="color: \
grey">(1140302)</span></li>
<li>trunk/KDE/kdelibs/kdeui/tests/kiconloader_unittest.cpp <span style="color: \
grey">(1140302)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4403/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic