This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4403/ |
On June 20th, 2010, 6:39 p.m., Michael Pyne wrote:
I'll not that KIconLoader is not "incorrect" in that the icon-theme-spec does specify that hicolor should be searched if the desired icon does not exist in a theme. shared-mime-info kind of overrides that by saying that if no specific icon is located, to search for a generic fallback icon, but that should only be mime icons. One question is what do we do if hicolor happens to have an exact match of the required size, do we accept hicolor or try to fallback to generic? I would say accept hicolor's more specific video-mp4 in preference to video-x-generic, but that could look ugly in several themes.
As an artist, I'd say ship it. If the name spec says something different, I think we should change it. I've not reviewed this patch code-wise though. For the second problem of yours, but still as an artistic advice, I'd say it's better to load the generic mime icon over accepting hicolor's specific version.
- Riccardo
On June 20th, 2010, 9:18 a.m., Aurélien Gâteau wrote:
Review request for kdelibs and Rafael Fernández López.
By Aurélien Gâteau.
Updated 2010-06-20 09:18:37 Description
Testing
Diffs
|