[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: keyboard2 moved to kdereview
From:       Andriy Rysin <arysin () gmail ! com>
Date:       2010-05-11 2:21:16
Message-ID: AANLkTilzJ9ABFAmT96IdhWwSoqQXrxkF1t8NusKKUtsB () mail ! gmail ! com
[Download RAW message or body]

2010/5/9 Andriy Rysin <arysin@gmail.com>

> It's been two weeks and I've just pushed the last changes in kdereview I
> wanted to make in. Now all the features that existed before in kxkb are
> still supported in keyboard module plus the new improvements. So I am
> planning to push the change on Monday.
>
> I don't think I can move in svn and update the build files at the same time
> so here are the steps I am planning to make:
>
> 1) remove kxkb from kcontrol/CMakeFiles.txt + delete kcontrol/keyboard and
> kcontrol/kxkb
> 2) move kdereview/keyboard2 to kcontrol/keyboard
> 3) update krunner/lock/lockdlg.cc to point to new keyboard layout widget
> library
>
> There will be a compiling problem if checking out the revision between 1
> and 2 but I'll do all steps fairly quickly so should not be a problem.
>
> If there's better (transactional) way to do these things please let me
> know. Also let me know if instead of deleting old keyboard and kxkb it's
> better to move them to unsupported/.
>
> Also I swear I edited the feature list before soft feature freeze to
> include these changes but they did not make it in (I guess I could have
> pressed review instead of submit) so after the svn push I'll add those
> features marked as "Done".
>
> After that only some minor improvements and potentially bug fixes are due.
>

The change is pushed and the feature list is updated.

Please let me know if you see any problems,
Thanks,
Andriy

[Attachment #3 (text/html)]

<div class="gmail_quote">2010/5/9 Andriy Rysin <span dir="ltr">&lt;<a \
href="mailto:arysin@gmail.com">arysin@gmail.com</a>&gt;</span><br><blockquote \
class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, \
204, 204); padding-left: 1ex;"> It&#39;s been two weeks and I&#39;ve just pushed the \
last changes in kdereview I wanted to make in. Now all the features that existed \
before in kxkb are still supported in keyboard module plus the new improvements. So I \
am planning to push the change on Monday.<br>

<br>I don&#39;t think I can move in svn and update the build files at the same time \
so here are the steps I am planning to make:<br><br>1) remove kxkb from \
kcontrol/CMakeFiles.txt + delete kcontrol/keyboard and kcontrol/kxkb<br>

2) move kdereview/keyboard2 to kcontrol/keyboard<br>3) update krunner/lock/lockdlg.cc \
to point to new keyboard layout widget library<br><br>There will be a compiling \
problem if checking out the revision between 1 and 2 but I&#39;ll do all steps fairly \
quickly so should not be a problem.<br>

<br>If there&#39;s better (transactional) way to do these things please let me know. \
Also let me know if instead of deleting old keyboard and kxkb it&#39;s better to move \
them to unsupported/.<br><br>Also I swear I edited the feature list before soft \
feature freeze to include these changes but they did not make it in (I guess I could \
have pressed review instead of submit) so after the svn push I&#39;ll add those \
features marked as &quot;Done&quot;.<br>

<br>After that only some minor improvements and potentially bug fixes are \
due.<br></blockquote><div> </div><div>The change is pushed and the feature list is \
updated.<br><br>Please let me know if you see any problems,<br> \
Thanks,<br>Andriy<br></div><div> </div></div>



[prev in list] [next in list] [prev in thread] [next in thread]