[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: KAuth support in KDM kcontrol module
From:       "Igor Krivenko" <igor () shg ! ru>
Date:       2010-05-03 19:48:05
Message-ID: 20100503194805.21556.80318 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3631/
-----------------------------------------------------------

(Updated 2010-05-03 19:48:05.066373)


Review request for kdelibs, usability, Dario Freddi, Oswald Buddenhagen, and Frederik \
Gladhorn.


Changes
-------

executeAction() is static now.

> hmm, i assumed that the knewstuff+kauth integration would be code-wise \
> self-contained in that regard, so that "our" executeAction() would be irrelevant \
> for it.

Well, but what do we do with "Install new theme" and "Remove theme" buttons? As I can \
see there are 4 options: 1) remove them completely - just drop a possibility to \
install themes from local files 2) keep them as is (disabled for everyone but admin)
3) port them to KAuth (introduce one more KAuth action)
4) remove them and wait until KNewStuff3 supports installation from local files \
(AFAIK this isn't a trivial task and Frederik doesn't have enough time for it right \
now)


Summary
-------

This is a patch for KDM kcontrol module.
It implements Kauth support for changing kdm settings and managing user images. 
It still doesn't support installation/deletion of themes (including installation via \
knewstuff). As far as I know there were plans to port KNewStuff3 to KAuth, so a more \
consistent approach is to rely on the KNewStuff's integration when it's available.


Diffs (updated)
-----

  /trunk/KDE/kdebase/workspace/kcontrol/kdm/CMakeLists.txt 1121893 
  /trunk/KDE/kdebase/workspace/kcontrol/kdm/background.h 1121893 
  /trunk/KDE/kdebase/workspace/kcontrol/kdm/background.cpp 1121893 
  /trunk/KDE/kdebase/workspace/kcontrol/kdm/helper.h PRE-CREATION 
  /trunk/KDE/kdebase/workspace/kcontrol/kdm/helper.cpp PRE-CREATION 
  /trunk/KDE/kdebase/workspace/kcontrol/kdm/kcmkdm_actions.actions PRE-CREATION 
  /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-conv.h 1121893 
  /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-conv.cpp 1121893 
  /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-dlg.h 1121893 
  /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-dlg.cpp 1121893 
  /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-gen.h 1121893 
  /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-gen.cpp 1121893 
  /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-shut.h 1121893 
  /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-shut.cpp 1121893 
  /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-theme.h 1121893 
  /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-theme.cpp 1121893 
  /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-users.h 1121893 
  /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-users.cpp 1121893 
  /trunk/KDE/kdebase/workspace/kcontrol/kdm/main.h 1121893 
  /trunk/KDE/kdebase/workspace/kcontrol/kdm/main.cpp 1121893 

Diff: http://reviewboard.kde.org/r/3631/diff


Testing
-------


Screenshots
-----------

Saving KDM settings
  http://reviewboard.kde.org/r/3631/s/360/
Managing user images
  http://reviewboard.kde.org/r/3631/s/361/


Thanks,

Igor


[prev in list] [next in list] [prev in thread] [next in thread]