[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: KAuth support in KDM kcontrol module
From:       "Oswald Buddenhagen" <ossi () kde ! org>
Date:       2010-05-03 21:37:35
Message-ID: 20100503213735.25591.16721 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3631/#review5381
-----------------------------------------------------------


hmm, you have a point here. i don't like entirely removing the feature, so option 3 \
would be best for now. now you have the option to duplicate the respective string in \
each call as you had it before or duplicate the whole function. i think i'd go for \
the latter in this case, as the function is quite short and the gained legibility of \
the code is worth it. but the functions should get more descriptive names, like \
executeFaceAction() and executeThemeAction() or something like that.

- Oswald


On 2010-05-03 19:48:05, Igor Krivenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3631/
> -----------------------------------------------------------
> 
> (Updated 2010-05-03 19:48:05)
> 
> 
> Review request for kdelibs, usability, Dario Freddi, Oswald Buddenhagen, and \
> Frederik Gladhorn. 
> 
> Summary
> -------
> 
> This is a patch for KDM kcontrol module.
> It implements Kauth support for changing kdm settings and managing user images. 
> It still doesn't support installation/deletion of themes (including installation \
> via knewstuff). As far as I know there were plans to port KNewStuff3 to KAuth, so a \
> more consistent approach is to rely on the KNewStuff's integration when it's \
> available. 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdebase/workspace/kcontrol/kdm/CMakeLists.txt 1121893 
> /trunk/KDE/kdebase/workspace/kcontrol/kdm/background.h 1121893 
> /trunk/KDE/kdebase/workspace/kcontrol/kdm/background.cpp 1121893 
> /trunk/KDE/kdebase/workspace/kcontrol/kdm/helper.h PRE-CREATION 
> /trunk/KDE/kdebase/workspace/kcontrol/kdm/helper.cpp PRE-CREATION 
> /trunk/KDE/kdebase/workspace/kcontrol/kdm/kcmkdm_actions.actions PRE-CREATION 
> /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-conv.h 1121893 
> /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-conv.cpp 1121893 
> /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-dlg.h 1121893 
> /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-dlg.cpp 1121893 
> /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-gen.h 1121893 
> /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-gen.cpp 1121893 
> /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-shut.h 1121893 
> /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-shut.cpp 1121893 
> /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-theme.h 1121893 
> /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-theme.cpp 1121893 
> /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-users.h 1121893 
> /trunk/KDE/kdebase/workspace/kcontrol/kdm/kdm-users.cpp 1121893 
> /trunk/KDE/kdebase/workspace/kcontrol/kdm/main.h 1121893 
> /trunk/KDE/kdebase/workspace/kcontrol/kdm/main.cpp 1121893 
> 
> Diff: http://reviewboard.kde.org/r/3631/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Saving KDM settings
> http://reviewboard.kde.org/r/3631/s/360/
> Managing user images
> http://reviewboard.kde.org/r/3631/s/361/
> 
> 
> Thanks,
> 
> Igor
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]