[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Polkit-qt, Polkit-qt-1 and polkit-kde new releases
From:       Alexander Neundorf <neundorf () kde ! org>
Date:       2009-12-24 10:05:13
Message-ID: 200912241105.13854.neundorf () kde ! org
[Download RAW message or body]

Hi Dario,

On Wednesday 23 December 2009, Dario Freddi wrote:
...
> Trunk now opt-depends on these new versions of polkit-qt*. I apologize for
> the late move, but it was necessary, since polkit-qt-1 still did not have a
> proper release, and polkit-qt suffered from 2 major problems (version check
> depending on pkgconfig and a bug in QtDBus in Qt 4.6) that required a
> release and a dependency on the new version to be fixed.

there have been build errors this night due to this change:
http://my.cdash.org/viewConfigure.php?buildid=42700

Not sure why, since the code in FindPolQt.cmake looks actually ok on the first 
sight, but maybe the attached patchs helps. 
Please have a look and commit if you find it works.

(I'm away now for the next few days)

Merry Christmas
Alex



["FindPolkitQt.cmake.patch" (text/x-diff)]

Index: FindPolkitQt.cmake
===================================================================
--- FindPolkitQt.cmake	(revision 1065783)
+++ FindPolkitQt.cmake	(working copy)
@@ -48,7 +48,7 @@
 
 set(POLKITQT_VERSION_OK TRUE)
 if(POLKITQT_VERSION_FILE)
-  file(READ ${POLKITQT_INCLUDE_DIR}/polkit-qt/polkitqtversion.h \
POLKITQT_VERSION_CONTENT) +  file(READ ${POLKITQT_VERSION_FILE} \
POLKITQT_VERSION_CONTENT)  string (REGEX MATCH "POLKITQT_VERSION_STRING \".*\"\n" \
POLKITQT_VERSION_MATCH "${POLKITQT_VERSION_CONTENT}")  
   if(POLKITQT_VERSION_MATCH)



[prev in list] [next in list] [prev in thread] [next in thread]