[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Add versioning check for thumbnailers.
From:       "Christoph Feck" <christoph () maxiom ! de>
Date:       2009-11-27 0:27:42
Message-ID: 20091127002742.21345.25579 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2282/#review3312
-----------------------------------------------------------


Looks better :) Btw, does it already handle old thumbnails from 4.3? If this fixes \
updating those thumbnails to get correct rotation, it should be applied for 4.4. This \
is actually a smart solution, as we have no other way yet to force an update of the \
thumbnails. And I agree with you on the == issues. Whenever a thumbnail is detected \
from an old thumbnailer, it should be updated.

But the version should then only be updated if the generated thumbnail actually may \
be different, not just if the author thinks he made a cool new release. That needs to \
be documented somehow (and somewhere).

- Christoph


On 2009-11-26 22:08:59, Jacopo De Simoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2282/
> -----------------------------------------------------------
> 
> (Updated 2009-11-26 22:08:59)
> 
> 
> Review request for kdelibs, Peter Penz, David Nolden, and David Faure.
> 
> 
> Summary
> -------
> 
> Adds versioning check for thumbnailers; the code checks if a ThumbnailerVersion is \
> defined and if so, checks that the software field in the existing thumbnail matches \
> before using the cached thumbnail.  
> This fixes caching bugs with the improved jpeg thumbnailer.
> 
> 
> Diffs
> -----
> 
> trunk/KDE/kdelibs/kio/kio/previewjob.cpp 1038240 
> 
> Diff: http://reviewboard.kde.org/r/2282/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jacopo
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]