[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Add versioning check for thumbnailers.
From:       "Jacopo De Simoi" <wilderkde () gmail ! com>
Date:       2009-11-26 22:09:00
Message-ID: 20091126220900.17227.94028 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2282/
-----------------------------------------------------------

(Updated 2009-11-26 22:08:59.947907)


Review request for kdelibs, Peter Penz, David Nolden, and David Faure.


Changes
-------

Correctly check for version numbers; handles the X.y.z case only; it should be good \
enough for thumbnailers (I don't expect to have more complicated versioning for them)


Summary
-------

Adds versioning check for thumbnailers; the code checks if a ThumbnailerVersion is \
defined and if so, checks that the software field in the existing thumbnail matches \
before using the cached thumbnail. 

This fixes caching bugs with the improved jpeg thumbnailer.


Diffs (updated)
-----

  trunk/KDE/kdelibs/kio/kio/previewjob.cpp 1038240 

Diff: http://reviewboard.kde.org/r/2282/diff


Testing
-------


Thanks,

Jacopo


[prev in list] [next in list] [prev in thread] [next in thread]