[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Adding support to KMimeType for guessing the
From:       "Friedrich W. H. Kossebau" <kossebau () kde ! org>
Date:       2009-09-27 20:19:57
Message-ID: 200909272219.58375.kossebau () kde ! org
[Download RAW message or body]

Hi Michael,

Samedi, le 26 septembre 2009, à 20:51, Michael Pyne a écrit:
> On Saturday 26 September 2009 12:14:51 Friedrich W. H. Kossebau wrote:
> > There is no new logic contained in this patch, but (just) two more
> > symbols to the API, resulting in a more powerful usage of KMimeType due
> > to the abtract QIODevice interface which can now be passed as content
> > provider instead of only a (local) file or a QByteArray.
> >
> > So I am considering to simply commit it. But I still would like at least
> >  one +1 from someone with insight.
>
> The patch looks technically correct (and I agree with the idea behind it as
> well).  I don't have any background insight as to KMT however.
>
> One quibble is that findByNameAndContent is missing the @return APIDOX.

Indeed, also missing from the original method I copied from. Will add, should 
be the same as in all the other methods.

> Other than that it looks fine to me.

Will commit on Monday, then.

Thanks for the review :)
Friedrich
-- 
Okteta - KDE 4 Hex Editor - http://utils.kde.org/projects/okteta

[prev in list] [next in list] [prev in thread] [next in thread]