[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Adding support to KMimeType for guessing the
From:       Michael Pyne <mpyne () kde ! org>
Date:       2009-09-26 18:51:04
Message-ID: 200909261451.10975.mpyne () kde ! org
[Download RAW message or body]


On Saturday 26 September 2009 12:14:51 Friedrich W. H. Kossebau wrote:
> There is no new logic contained in this patch, but (just) two more symbols
>  to the API, resulting in a more powerful usage of KMimeType due to the
>  abtract QIODevice interface which can now be passed as content provider
>  instead of only a (local) file or a QByteArray.
> 
> So I am considering to simply commit it. But I still would like at least
>  one +1 from someone with insight.

The patch looks technically correct (and I agree with the idea behind it as 
well).  I don't have any background insight as to KMT however.

One quibble is that findByNameAndContent is missing the @return APIDOX.

Other than that it looks fine to me.

Regards,
 - Michael Pyne

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]