[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Add thubnail support for Microsoft Windows
From:       "Matthew Woehlke" <mw_triad () users ! sourceforge ! net>
Date:       2009-09-14 18:26:09
Message-ID: 20090914182609.21327.85057 () localhost
[Download RAW message or body]



> On 2009-09-14 16:05:40, David Faure wrote:
> > Converting a .ico to a .png can be done with Qt's .ico support, no?
> > But since extracting icons from an .exe needs these icotools anyway, this \
> > wouldn't allow dropping the dependency, it would just make the ico-to-png \
> > conversion faster, I guess.
> 
> Pali Rohár wrote:
> Convert ico to png is in QImage bad. Qt only get first picture from ico file, but \
> ico file can have more pictures. Then first picture is 16x16 second 32x32, ... so \
> in Qt is still smallest icon (and 16x16 is very small). With program icotool, I can \
> extract largest icon (it is implemented in this patch), not only first.

(WCTS) is that what it actually does? It would be better to extract the size closest \
to the size of the thumbnail you are making.


- Matthew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1533/#review2353
-----------------------------------------------------------


On 2009-09-08 13:42:30, Pali Rohár wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1533/
> -----------------------------------------------------------
> 
> (Updated 2009-09-08 13:42:30)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This patch add thubnail support for Microsoft Windows executables (.exe, .dll, \
> .ocx, ...) and images (.ico, .cur, ...) in konqueror/dolphin. 
> It use external applications icoutils from http://www.nongnu.org/icoutils/
> 
> 
> This addresses bug 185348.
> https://bugs.kde.org/show_bug.cgi?id=185348
> 
> 
> Diffs
> -----
> 
> trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowsimagethumbnail.desktop \
> PRE-CREATION  trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowsimagecreator.h \
> PRE-CREATION  trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowsimagecreator.cpp \
> PRE-CREATION  trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowsexecreator.h \
> PRE-CREATION  trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowsexecreator.cpp \
> PRE-CREATION  trunk/KDE/kdebase/runtime/kioslave/thumbnail/windowsexethumbnail.desktop \
> PRE-CREATION  trunk/KDE/kdebase/runtime/kioslave/thumbnail/icoutils.cpp \
> PRE-CREATION  trunk/KDE/kdebase/runtime/kioslave/thumbnail/CMakeLists.txt 1021172 
> trunk/KDE/kdebase/runtime/kioslave/thumbnail/icoutils.h PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/1533/diff
> 
> 
> Testing
> -------
> 
> With wine it works fine for me.
> 
> 
> Thanks,
> 
> Pali
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]