[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: New KSignalPlotter graph for plotting continuous
From:       "Allen Winter" <winter () kde ! org>
Date:       2009-09-14 13:48:23
Message-ID: 20090914134823.13874.92798 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1430/#review2348
-----------------------------------------------------------


I'd like to see this go into kdelibs.

Looks very nice: you have apidox, d-pointers, and the API seems fine.

Probably you should use the new debug area stuff.

Maybe you could add a few more usage examples to the apidox, or even write up a \
tutorial on TechBase.. ?

anyway.. I'd ship this.

- Allen


On 2009-08-29 10:45:29, John Tapsell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1430/
> -----------------------------------------------------------
> 
> (Updated 2009-08-29 10:45:29)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This is used by KSysGuard to plot network usage etc.  I want to make it available \
> for other people to use. 
> It is really quite feature-full, and uses a sliding window technique to minimize \
> CPU usage for drawing.  On my system (dual core 3Ghz), drawing three of these \
> graphs updating every 0.5 seconds takes about 1% of the CPU usage. 
> 
> Diffs
> -----
> 
> trunk/KDE/kdeui/plotting/KSignalPlotter.h PRE-CREATION 
> trunk/KDE/kdeui/plotting/KSignalPlotter.cpp PRE-CREATION 
> trunk/KDE/kdeui/plotting/KSignalPlotter_p.h PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/1430/diff
> 
> 
> Testing
> -------
> 
> It has been used in KSysGuard for ages.
> 
> It has no unit tests however :-/
> 
> 
> Screenshots
> -----------
> 
> Screenshot in action
> http://reviewboard.kde.org/r/1430/s/191/
> 
> 
> Thanks,
> 
> John
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]