[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: New KSignalPlotter graph for plotting continuous
From:       "John Tapsell" <johnflux () gmail ! com>
Date:       2009-09-14 11:37:17
Message-ID: 20090914113717.10279.28385 () localhost
[Download RAW message or body]



> On 2009-09-14 11:09:06, David Faure wrote:
> > The rule in kdelibs is "2 (preferrably 3) other apps wanting to use it".
> > From what you say, this isn't the case yet, right?
> > 
> > Of course this is a chicken-and-egg problem, people can't use it if it's not \
> > available. But in fact this is what \
> > http://techbase.kde.org/Projects/Widgets_and_Classes is for (I suggest you add \
> > the class there), and well, this very review request would also trigger "I want \
> > this" from app authors who need something like this, if there were ;-) Meanwhile \
> > I don't think we should put this in kdelibs - no point in forcing ourselves into \
> > SC/BC rules until necessary.

Well I keep seeing people using it for plasmoids.  Like \
http://www.kde-look.org/content/show.php/Complex+Plotter?content=111400&PHPSESSID=c12c3d7f0bba1cc60cafff583f60e1e7 \
and I've seen it appear in various screenshots.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1430/#review2346
-----------------------------------------------------------


On 2009-08-29 10:45:29, John Tapsell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1430/
> -----------------------------------------------------------
> 
> (Updated 2009-08-29 10:45:29)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This is used by KSysGuard to plot network usage etc.  I want to make it available \
> for other people to use. 
> It is really quite feature-full, and uses a sliding window technique to minimize \
> CPU usage for drawing.  On my system (dual core 3Ghz), drawing three of these \
> graphs updating every 0.5 seconds takes about 1% of the CPU usage. 
> 
> Diffs
> -----
> 
> trunk/KDE/kdeui/plotting/KSignalPlotter.h PRE-CREATION 
> trunk/KDE/kdeui/plotting/KSignalPlotter.cpp PRE-CREATION 
> trunk/KDE/kdeui/plotting/KSignalPlotter_p.h PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/1430/diff
> 
> 
> Testing
> -------
> 
> It has been used in KSysGuard for ages.
> 
> It has no unit tests however :-/
> 
> 
> Screenshots
> -----------
> 
> Screenshot in action
> http://reviewboard.kde.org/r/1430/s/191/
> 
> 
> Thanks,
> 
> John
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]