[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Jpeg thumbnailer honouring  jpeg rotation info
From:       "Jacopo De Simoi" <wilderkde () gmail ! com>
Date:       2009-08-30 21:33:48
Message-ID: 20090830213348.14586.7189 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1444/
-----------------------------------------------------------

(Updated 2009-08-30 21:33:48.546450)


Review request for kdelibs.


Changes
-------

Applied suggestions by Peter + less whitespace around ()
CMakeList suggestions by Parker will be submitted after he reviews my concerns.

Thanks


Summary
-------

This patch makes the jpeg thumbnailer honor jpeg rotation infos stored in exif metadata. 
The method is quite simple, although I don't like ifdefs, this time they seem to me to be necessary.
It's my first nontrivial CMake modification; please check that I did not do something stupid there.
Also, the orientationMatrix method could be ifdeffed if you feel it is necessary; I just didn't want to \
add another ifdef.

I am not sure if this is a good solution performance-wise; please comment on that if you have better \
ideas.


Diffs (updated)
-----

  branches/KDE/4.3/kdebase/runtime/kioslave/thumbnail/CMakeLists.txt 1016603 
  branches/KDE/4.3/kdebase/runtime/kioslave/thumbnail/jpegcreator.h 1016603 
  branches/KDE/4.3/kdebase/runtime/kioslave/thumbnail/jpegcreator.cpp 1016603 

Diff: http://reviewboard.kde.org/r/1444/diff


Testing
-------

Works good with a *clean* .thumbnails directory. Cached thumbnails are indeed a problem; not sure how to \
solve this issue yet.


Screenshots
-----------

Dolphin showing correctly rotated jpegs
  http://reviewboard.kde.org/r/1444/s/192/


Thanks,

Jacopo


[prev in list] [next in list] [prev in thread] [next in thread]