[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Jpeg thumbnailer honouring jpeg rotation info
From: "Jacopo De Simoi" <wilderkde () gmail ! com>
Date: 2009-08-30 21:30:40
Message-ID: 20090830213040.14655.35454 () localhost
[Download RAW message or body]
> On 2009-08-30 15:17:39, Parker Coates wrote:
> > branches/KDE/4.3/kdebase/runtime/kioslave/thumbnail/CMakeLists.txt, lines 48-52
> > <http://reviewboard.kde.org/r/1444/diff/3/?file=10835#file10835line48>
> >
> > ... and "include_directories(${EXIV2_INCLUDE_DIR})" here, as it gets rid of the first if/else \
> > statement.
I'm fine with that, I was initially reluctant because it seemed to me that the include_directories cannot \
be done on a per-target basis and therefore should be taken care for before the target list. If that's \
not an issue I'll happily peruse your suggestion.
On 2009-08-30 15:17:39, Jacopo De Simoi wrote:
> > Also the unnecessary white space changes should probably be removed.
mmh, I should probably fix them in advance with SVN_SILENT and then resubmit the patch;
my editor itself takes care of fixing whitespaces, I think it's not a bad thing.
- Jacopo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1444/#review2187
-----------------------------------------------------------
On 2009-08-30 12:58:47, Jacopo De Simoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1444/
> -----------------------------------------------------------
>
> (Updated 2009-08-30 12:58:47)
>
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> This patch makes the jpeg thumbnailer honor jpeg rotation infos stored in exif metadata.
> The method is quite simple, although I don't like ifdefs, this time they seem to me to be necessary.
> It's my first nontrivial CMake modification; please check that I did not do something stupid there.
> Also, the orientationMatrix method could be ifdeffed if you feel it is necessary; I just didn't want to \
> add another ifdef.
> I am not sure if this is a good solution performance-wise; please comment on that if you have better \
> ideas.
>
> Diffs
> -----
>
> branches/KDE/4.3/kdebase/runtime/kioslave/thumbnail/CMakeLists.txt 1016603
> branches/KDE/4.3/kdebase/runtime/kioslave/thumbnail/jpegcreator.h 1016603
> branches/KDE/4.3/kdebase/runtime/kioslave/thumbnail/jpegcreator.cpp 1016603
>
> Diff: http://reviewboard.kde.org/r/1444/diff
>
>
> Testing
> -------
>
> Works good with a *clean* .thumbnails directory. Cached thumbnails are indeed a problem; not sure how \
> to solve this issue yet.
>
> Screenshots
> -----------
>
> Dolphin showing correctly rotated jpegs
> http://reviewboard.kde.org/r/1444/s/192/
>
>
> Thanks,
>
> Jacopo
>
>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic