[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Fix sanitization of dbus path in KMainWindow
From:       Thomas =?iso-8859-15?q?L=FCbking?= <thomas.luebking () web ! de>
Date:       2009-08-18 13:34:12
Message-ID: 200908181534.12971.thomas.luebking () web ! de
[Download RAW message or body]

Am Tuesday 18 August 2009 schrieb Thiago Macieira:

> It means you just misused QString.
Indeed - forcing QString::fromUtf8("ß") makes it work as expected.
Good to know =D
(The Qt docu states that QString(const *char) makes implicit use of 
QString::fromAscii())

> Please compile your code with #define QT_NO_CAST_FROM_ASCII and
> QT_NO_CAST_TO_ASCII.
this would be more like a call to whoever set an objectName/appName using 
utf-8 (and is pretty nasty in it's effect, btw ;-)

Another thing:
the '_' substitution may be ambigious as e.g. "_sen" and "_sen" are the very 
same strings...
i'd suggest to insert _<unicode>_ instead, so "_214_sen" and "_228_sen" remain 
individual (unless not used othwerwise... it's a far corner case anyway)

Regards and thanks for yet another lesson,
Thomas

[prev in list] [next in list] [prev in thread] [next in thread]