[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request: Fix sanitization of dbus path in KMainWindow
From:       "Matthew Woehlke" <mw_triad () users ! sourceforge ! net>
Date:       2009-08-10 22:27:09
Message-ID: 20090810222709.30502.25598 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1261/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

As pointed out by Thomas Lübking ( \
http://permalink.gmane.org/gmane.comp.kde.devel.general/58749 ), KMainWindow attempts \
to sanitize what it will allow in the dbus path. However as written it would allow \
the illegal characters "." and "-" to be passed through.


Diffs
-----

  /trunk/KDE/kdelibs/kdeui/widgets/kmainwindow.cpp 1009802 

Diff: http://reviewboard.kde.org/r/1261/diff


Testing
-------

built kdelibs and ran a KDE application


Thanks,

Matthew


[prev in list] [next in list] [prev in thread] [next in thread]