From kde-core-devel  Mon Aug 10 22:27:09 2009
From: "Matthew Woehlke" <mw_triad () users ! sourceforge ! net>
Date: Mon, 10 Aug 2009 22:27:09 +0000
To: kde-core-devel
Subject: Review Request: Fix sanitization of dbus path in KMainWindow
Message-Id: <20090810222709.30502.25598 () localhost>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=124994323305950


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1261/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

As pointed out by Thomas Lübking ( http://permalink.gmane.org/gmane.comp.kde.devel.general/58749 ), KMainWindow attempts to sanitize what it will allow in the dbus path. However as written it would allow the illegal characters "." and "-" to be passed through.


Diffs
-----

  /trunk/KDE/kdelibs/kdeui/widgets/kmainwindow.cpp 1009802 

Diff: http://reviewboard.kde.org/r/1261/diff


Testing
-------

built kdelibs and ran a KDE application


Thanks,

Matthew