[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: kio_sftp rewrite
From:       Andreas Schneider <mail () cynapses ! org>
Date:       2009-08-10 9:32:48
Message-ID: 200908101132.48631.mail () cynapses ! org
[Download RAW message or body]


On Sunday 09 August 2009 21:12:47 Dawit A. wrote:
> Well if you have a screwed up ssh server that refuses connection like I do
> right now, then kio_sftp with your changes SEGFAULTS and I think I know
> why... There is a code that does the following in openConnection:
>
>   sftp_session = sftp_new(ssh_session);
>   if (sftp_session == NULL) {
>     closeConnection();
>     return;
>   }

Hi Dawit,

there should be an error() call before the return. Could you attach gdb and 
get a backtrace?

> but unfortunately, closeConnection also does...
>
>   sftp_free(sftp_session);
>   sftp_session = NULL;
>
> so if sftp_session is already NULL as in the above case, then the ioslave
> goes down in flames. Once I get around to fixing my ssh server, I will test
> basic functionality and let you know, but I think it should be fine to
> commit this into the main tree on work on improving it from there, no ?

Hmm, it should not segfault.

 226 void sftp_free(SFTP_SESSION *sftp){
 227   struct request_queue *ptr;
 228
 229   if (sftp == NULL) {
 230     return;
 231   }



	-- andreas

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]