From kde-core-devel  Mon Aug 10 09:32:48 2009
From: Andreas Schneider <mail () cynapses ! org>
Date: Mon, 10 Aug 2009 09:32:48 +0000
To: kde-core-devel
Subject: Re: kio_sftp rewrite
Message-Id: <200908101132.48631.mail () cynapses ! org>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=124989692621924
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--nextPart1391681.zNmsCWPnB9"

--nextPart1391681.zNmsCWPnB9
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

On Sunday 09 August 2009 21:12:47 Dawit A. wrote:
> Well if you have a screwed up ssh server that refuses connection like I do
> right now, then kio_sftp with your changes SEGFAULTS and I think I know
> why... There is a code that does the following in openConnection:
>
>   sftp_session =3D sftp_new(ssh_session);
>   if (sftp_session =3D=3D NULL) {
>     closeConnection();
>     return;
>   }

Hi Dawit,

there should be an error() call before the return. Could you attach gdb and=
=20
get a backtrace?

> but unfortunately, closeConnection also does...
>
>   sftp_free(sftp_session);
>   sftp_session =3D NULL;
>
> so if sftp_session is already NULL as in the above case, then the ioslave
> goes down in flames. Once I get around to fixing my ssh server, I will te=
st
> basic functionality and let you know, but I think it should be fine to
> commit this into the main tree on work on improving it from there, no ?

Hmm, it should not segfault.

 226 void sftp_free(SFTP_SESSION *sftp){
 227   struct request_queue *ptr;
 228
 229   if (sftp =3D=3D NULL) {
 230     return;
 231   }



	-- andreas

--nextPart1391681.zNmsCWPnB9
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)

iEYEABECAAYFAkp/6UAACgkQf94+j/M+P8aYbwCgopFg23BNUYA2o5b4eOajrioX
NcwAnRnczm+64/EqNqqKyK9wQ5+R9L0f
=frQi
-----END PGP SIGNATURE-----

--nextPart1391681.zNmsCWPnB9--