[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Support for dynamic areas in KDebug
From:       "David Faure" <faure () kde ! org>
Date:       2009-07-03 7:54:32
Message-ID: 20090703075432.2928.18362 () localhost
[Download RAW message or body]



> On 2009-07-02 13:40:05, Pino Toscano wrote:
> > The only convern I have is about still being able to disable some debug area. If \
> > an application registers his area automatically, kdebugdialog doesn't know that, \
> > so you cannot disable its area... Even if there's some option to disable all the \
> > dynamic areas, it could be suboptimal, as 3rd part developers could need to have \
> > the debug of their application active, while disabling it for all the other ones.
> 
> Oswald Buddenhagen wrote:
> i'm not worried. i don't know if this already implemented or not, but remembering \
> the areas that were used at some point seems fairly trivial. and you wouldn't want \
> to see, let alone disable an area which was never used before anyway.

That's exactly what I implemented in kdebugdialog. When an application registers an \
area, it gets written to kdebugrc, and kdebugdialog picks that up and offers \
checkboxes for named areas as well. http://www.davidfaure.fr/2009/kdebugdialog.diff

But indeed this means that the "deselect all" button in kdebugdialog will only \
disable all already-seen debug areas, but not all areas from applications not \
launched yet. Which is a problem for kubuntu's use case (they seem to compile with \
debug enabled but disable all areas in kdebugrc, so that users can re-enable areas if \
needed). For this to be possible with dynamic areas we need something else... like a \
global checkbox "new dynamic areas are enabled or disabled by default". Or simply a \
global checkbox "disable all debug output".


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/927/#review1443
-----------------------------------------------------------


On 2009-07-02 12:10:52, David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/927/
> -----------------------------------------------------------
> 
> (Updated 2009-07-02 12:10:52)
> 
> 
> Review request for kdelibs and Pino Toscano.
> 
> 
> Summary
> -------
> 
> Support for dynamic areas in KDebug. Apps and libs can now request a debug area by \
> name at runtime, which removes the need for the static definition of areas in the \
> file kdebug.areas. 
> 
> Diffs
> -----
> 
> trunk/KDE/kdelibs/kdecore/io/kdebug.h 990274 
> trunk/KDE/kdelibs/kdecore/io/kdebug.cpp 990274 
> trunk/KDE/kdelibs/kdecore/tests/kdebug_unittest.h 990274 
> trunk/KDE/kdelibs/kdecore/tests/kdebug_unittest.cpp 990274 
> trunk/KDE/kdelibs/kdecore/tests/kdebugtest.cpp 990274 
> 
> Diff: http://reviewboard.kde.org/r/927/diff
> 
> 
> Testing
> -------
> 
> Unit tests; running kde apps with ported kdelibs and using the new kdebugdialog to \
> enable/disable dynamic areas. 
> 
> Thanks,
> 
> David
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]