[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Support for dynamic areas in KDebug
From:       "Albert Astals Cid" <aacid () kde ! org>
Date:       2009-07-02 20:54:57
Message-ID: 20090702205457.18204.43515 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/927/#review1444
-----------------------------------------------------------


Seems ok to me, for Pino's concern maybe we could add a env var that also adds \
dynamic zones to disable so we have KDE_DISABLE_DEBUG_ZONE=foo:bar:jdw

- Albert


On 2009-07-02 12:10:52, David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/927/
> -----------------------------------------------------------
> 
> (Updated 2009-07-02 12:10:52)
> 
> 
> Review request for kdelibs and Pino Toscano.
> 
> 
> Summary
> -------
> 
> Support for dynamic areas in KDebug. Apps and libs can now request a debug area by \
> name at runtime, which removes the need for the static definition of areas in the \
> file kdebug.areas. 
> 
> Diffs
> -----
> 
> trunk/KDE/kdelibs/kdecore/io/kdebug.h 990274 
> trunk/KDE/kdelibs/kdecore/io/kdebug.cpp 990274 
> trunk/KDE/kdelibs/kdecore/tests/kdebug_unittest.h 990274 
> trunk/KDE/kdelibs/kdecore/tests/kdebug_unittest.cpp 990274 
> trunk/KDE/kdelibs/kdecore/tests/kdebugtest.cpp 990274 
> 
> Diff: http://reviewboard.kde.org/r/927/diff
> 
> 
> Testing
> -------
> 
> Unit tests; running kde apps with ported kdelibs and using the new kdebugdialog to \
> enable/disable dynamic areas. 
> 
> Thanks,
> 
> David
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]