[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    KIconLoader::Dialog
From:       Christoph Feck <christoph () maxiom ! de>
Date:       2009-05-09 20:25:47
Message-ID: 200905092225.47363.christoph () maxiom ! de
[Download RAW message or body]

Hi,

Looking at the code to fix bug 153689 (item 3, as 1 and 2 are already fixed), 
I noticed a bug in kdebase/runtime/kcontrol/icons/icons.cpp, namely the usage 
of "KIconLoader::LastGroup".

This file assumes "LastGroup == Panel + 1" (see line 404) without noticing 
that "KIconLoader::Dialog" had been inserted (maybe during KDE 4 port?)

There are two options to fix this bug:

1) Adding the missing (translatable) string for "Dialog" to the usage combo 
box

2) work around it (maybe using "X > Panel " instead of "X == LastGroup")

Adding the string would actually add a feature (namely being able to change 
the size of "Dialog" icons), so I am not sure if option 1) is possible right 
now.

Thanks for comments,
Christoph Feck (kdepepo)

bug link: https://bugs.kde.org/show_bug.cgi?id=153689
[prev in list] [next in list] [prev in thread] [next in thread]