[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Upgrade TerminalInterface to V2 and add two more
From:       "Robert Knight" <robertknight () gmail ! com>
Date:       2009-03-28 21:49:12
Message-ID: 20090328214912.23016.27660 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/444/#review672
-----------------------------------------------------------


The method names are misleading.  There are two processes of interest - the shell or \
other program which Konsole itself started when the session was created (typically \
bash or some other shell) and the process which currently has control of the \
terminal.  UNIX documentation usually refers to this as the program group leader.  In \
Konsole we refer to this as he foreground process - this may be the shell itself.  \
Additionally, it is not necessary to have both isSubProcessActive() and \
subProcessPID() since subProcessID() returns -1 if there is no foreground process - \
which is something that can happen only when the terminal has just started or after \
it has just ended since after that, the foreground process is either the shell or \
some other program.

Instead I suggest having just two methods:

terminalProcessId() - Returns the PID of the terminal process which was started by \
the Konsole part (typically this program will be a shell which the user can enter \
commands into) foregroundProcessId() - Returns the PID of the process which is \
currently controlling the terminal.  This may be the same as terminalProcessId().  \
Returns -1 if there is no foreground process.

- Robert


On 2009-03-28 10:02:15, Rahman Duran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/444/
> -----------------------------------------------------------
> 
> (Updated 2009-03-28 10:02:15)
> 
> 
> Review request for kdelibs and Konsole.
> 
> 
> Summary
> -------
> 
> This is a new interface that extends the old ones functionality. 
> 
> 
> Diffs
> -----
> 
> trunk/KDE/kdelibs/interfaces/terminal/CMakeLists.txt 945618 
> trunk/KDE/kdelibs/interfaces/terminal/kde_terminal_interface_v2.h PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/444/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rahman
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]