[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Upgrade TerminalInterface to V2 and add two more
From:       "Rahman Duran" <rahman.duran () gmail ! com>
Date:       2009-03-28 17:02:16
Message-ID: 20090328170216.16852.33778 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/444/
-----------------------------------------------------------

(Updated 2009-03-28 10:02:15.892953)


Review request for kdelibs and Konsole.


Changes
-------

-Added more functions about sub processes.

-Removed the "hasInputData()" function as it seems impossible to implement this. I \
have implemented this function but its a dirty workaround that tries to guess if \
there is some input text waiting on command prompt. But there is many use cases that \
there should be this kind of text: pasting to command prompt, pressing double TAB, \
using shell history with UP, DOWN keys etc. My implementation handles user inputs \
which directly written. But this aproach seems to me not perfect and it doesn't (and \
can't) handle all use cases. It also depends on underlying shell. So simply I give up \
implementing this. I can be implemented only if the shell (bash, sh etc.) tell us if \
there is unprocessed input data on command propmt. Without this, it's simply \
impossible.


Summary
-------

This is a new interface that extends the old ones functionality. 


Diffs (updated)
-----

  trunk/KDE/kdelibs/interfaces/terminal/CMakeLists.txt 945618 
  trunk/KDE/kdelibs/interfaces/terminal/kde_terminal_interface_v2.h PRE-CREATION 

Diff: http://reviewboard.kde.org/r/444/diff


Testing
-------


Thanks,

Rahman


[prev in list] [next in list] [prev in thread] [next in thread]