[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Fwd: KFileDialog combined keyword/filename suggestion
From:       Albert Astals Cid <aacid () kde ! org>
Date:       2009-03-10 19:27:13
Message-ID: 200903102027.13786.aacid () kde ! org
[Download RAW message or body]

A Dimarts, 10 de març de 2009, Jonathan Marten va escriure:
> Updated patch now attached to bug 186230.
>
> Albert Astals Cid <aacid@kde.org> writes:
> > kDebug() needs to be removed or get the proper area (kfile_area)
>
> Corrected.
>
> > New getStartUrl needs @since KDE 4.3
>
> Added.
>
> > You need to provide proper API update for kfiledialog.h too (maybe it
> > would be a good idea just removing it from kfiledialog.h and put a link
> > to kfilewidget docu?)
>
> Updated API docs, documenting all uses of kfiledialog: URL in
> KFileWidget constructor and referring all other uses to there.
>
> > Also it would be good if you could update
> > kio/kfile/tests/kfiledialogtest.cpp with some tests covering all the new
> > cases.
>
> Added test cases there.

You forgot to attach the patch :D

Albert

>
> Regards and thanks,
>    Jonathan



[prev in list] [next in list] [prev in thread] [next in thread]