[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Fwd: KFileDialog combined keyword/filename suggestion
From:       Jonathan Marten <jjm2 () keelhaul ! demon ! co ! uk>
Date:       2009-03-10 13:38:57
Message-ID: oviqmhmr9q.fsf () keelhaul ! local
[Download RAW message or body]

Updated patch now attached to bug 186230.

Albert Astals Cid <aacid@kde.org> writes:

> kDebug() needs to be removed or get the proper area (kfile_area)
Corrected.

> New getStartUrl needs @since KDE 4.3
Added.

> You need to provide proper API update for kfiledialog.h too (maybe it would be 
> a good idea just removing it from kfiledialog.h and put a link to kfilewidget 
> docu?)
Updated API docs, documenting all uses of kfiledialog: URL in
KFileWidget constructor and referring all other uses to there.

> Also it would be good if you could update kio/kfile/tests/kfiledialogtest.cpp 
> with some tests covering all the new cases.
Added test cases there.

Regards and thanks,
   Jonathan

-- 
Jonathan Marten                         http://www.keelhaul.demon.co.uk
Twickenham, UK                          jjm2@keelhaul.demon.co.uk
[prev in list] [next in list] [prev in thread] [next in thread]