[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [Patch] add serial devices to solid
From:       Richard Moore <richmoore44 () gmail ! com>
Date:       2009-01-19 21:48:33
Message-ID: 5491a5150901191348q47111fb2r3975f0bcc2cd3165 () mail ! gmail ! com
[Download RAW message or body]

On Mon, Jan 19, 2009 at 9:15 PM, Kevin Ottens <ervin@kde.org> wrote:
> On Monday 19 January 2009 21:50:19 Harald Fernengel wrote:
> Only two things bug me API wise:
>  * QString ifaceName()
>   For this kind of things we use QVariant handle() (or something similar) at
>   other places of the API, would this one qualify for such a move?

I'd change ifaceName() etc. to interfaceName() there's no need to
abbreviate it and using the full word is clearer.

>
>  * QString serialType()
>   I'd really like this one use an enum instead, that's what we have
>   everywhere else in the API for this kind of cases.

I agree with Kevin that an enum would be good here. With Q_ENUM it's
easy to convert to a string if required.

I'm also a bit worried about  virtual int port() const; Doesn't this
only make sense for RS232 style serial ports?

Cheers

Rich.
[prev in list] [next in list] [prev in thread] [next in thread]