[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [Patch] add serial devices to solid
From:       Kevin Ottens <ervin () kde ! org>
Date:       2009-01-19 21:15:29
Message-ID: 200901192215.34105.ervin () kde ! org
[Download RAW message or body]


On Monday 19 January 2009 21:50:19 Harald Fernengel wrote:
> this patch adds support for serial devices (/dev/tty*) to solid.
> Required to access embedded devices or phone modems.

Only two things bug me API wise:
 * QString ifaceName()
   For this kind of things we use QVariant handle() (or something similar) at
   other places of the API, would this one qualify for such a move?

 * QString serialType()
   I'd really like this one use an enum instead, that's what we have
   everywhere else in the API for this kind of cases.

Otherwise it looks fine to me.

> Open Issues:
>
> * need an icon for serial ports

Would indeed be nice.

> * need a Windows implementation

So far we have only a partial windows backend anyway...

Regards.
-- 
Kévin 'ervin' Ottens, http://ervin.ipsquad.net
"Ni le maître sans disciple, Ni le disciple sans maître,
Ne font reculer l'ignorance."

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]