[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Smaller KDialogs if needed
From:       David Faure <faure () kde ! org>
Date:       2008-06-25 20:28:06
Message-ID: 200806252228.06831.faure () kde ! org
[Download RAW message or body]

On Sunday 22 June 2008, Albert Astals Cid wrote:
> A Diumenge 22 Juny 2008, Olivier Goffart va escriure:
> > Le samedi 21 juin 2008, Albert Astals Cid a écrit :
> > > KDialog uses the mainwidget sizeHint to calculate it's minimumSizeHint,
> > > this results in BIG KDialogs and bad situations like for example
> > > 	$ keditfiletype text/html
> > > not fitting in a 1024x768 screen.
> > >
> > > The attached patch first uses sizeHint and if the calculated
> > > minimumSizeHint is bigger than 90% of available screen rect recalculates
> > > the minimumSizeHint using children's minimumSizeHint.
> > >
> > > That gives me a keditfiletype that fits nicely in a 1024x768 screen.
> > >
> > > Comments?
> >
> > Don't you think kdialog should always compute the minimum sizehint from the
> > minimum size hint of it's contents?
> 
> It would seem sane yes, but if you do that, you'll end up with uglier dialogs 
> by default, many components define a minimum sizehint that is really minimum, 
> so that's why i just switched to using minimum sizehint if it does not fit.

I don't understand.

Yes, minimumSizeHint() is really minimum, but by default you get the sizeHint() of
all the widgets... so what's the problem with minimumSizeHint() being really minimum?
As long as you don't resize down the dialog, you don't see how small things can get...
Do you mean that you want to prevent people from making dialogs very small? Normally
if all minimumSizeHint()s (and size policies) are correct, the dialog should still be usable
even when using the minimumSizeHint of all widgets....


-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).

[prev in list] [next in list] [prev in thread] [next in thread]