[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Goya and KRichText
From:       Simon Hausmann <hausmann () kde ! org>
Date:       2008-05-13 8:44:00
Message-ID: 200805131044.01511.hausmann () kde ! org
[Download RAW message or body]


On Sunday 11 May 2008 23:39:22 Allen Winter wrote:
> Howdy,
>
> Toma and I think that Friday 16 May would be a nice time
> to move Goya and KRichText from kdereview into kdelibs.
>
> Unless there are objections to these libs, of course.
>
> This gives us 10 days of review, plus a few days before
> the hard feature freeze and the beta1 tagging.
>
> So.. please give a look to these goodies in kdereview
> in the next few days if you have some time.

Four small comments:

1) Is it intentional that KRichTextEdit has a public QString fileName member 
variable?

2) In KRichTextEdit many of the slots have a 'slot' prefix in their method 
name. I suggest to remove it, it's redundant.

3) I suggest to merge at least KRichTextWidget and KRichTextEditor into one 
class.

4) I suggest to remove 'NestedListHelper' from the public API.


Simon

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]