--nextPart4888741.erJjHpP5cb
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Sunday 11 May 2008 23:39:22 Allen Winter wrote:
> Howdy,
>
> Toma and I think that Friday 16 May would be a nice time
> to move Goya and KRichText from kdereview into kdelibs.
>
> Unless there are objections to these libs, of course.
>
> This gives us 10 days of review, plus a few days before
> the hard feature freeze and the beta1 tagging.
>
> So.. please give a look to these goodies in kdereview
> in the next few days if you have some time.

=46our small comments:

1) Is it intentional that KRichTextEdit has a public QString fileName membe=
r=20
variable?

2) In KRichTextEdit many of the slots have a 'slot' prefix in their method=
=20
name. I suggest to remove it, it's redundant.

3) I suggest to merge at least KRichTextWidget and KRichTextEditor into one=
=20
class.

4) I suggest to remove 'NestedListHelper' from the public API.


Simon

--nextPart4888741.erJjHpP5cb
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQBIKVTRWXvMThJCpvIRAtIBAKCp55RDCyHUl5WVEaytx3esusSg3gCgghVD
VMita0iQ+mJjul0+yWlCgKg=
=XBtw
-----END PGP SIGNATURE-----

--nextPart4888741.erJjHpP5cb--