[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Goya in kdereview
From:       Rafael =?iso-8859-1?q?Fern=E1ndez_L=F3pez?= <ereslibre () kde ! org>
Date:       2008-05-07 1:16:32
Message-ID: 200805070316.33194.ereslibre () kde ! org
[Download RAW message or body]


Hi,

Thanks for your checks Allen. I will tomorrow commit the Mainpage.dox.

> 1. Check for undocumented methods...  OOPS! 8 issues found!
>         kwidgetitemdelegate.h: 117, 138 (2)
>         kwidgetitemdelegatepool.cpp: 44, 46,47, 49, 50, 51 (6)

I can't find any method on kwidgetitemdelegate.h: 117 or 138. 117 is the 
beginning of a multi-line comment, and 138 is the d-pointer declaration.

> 2. Check for undocumented parameters...  OOPS! 1 issues found!
>         kwidgetitemdelegate.h: 128 (1)

Yeah, small one, it was written 'type' instead of 'types'. Thanks for that 
one.

> 3. Check for unknown parameters...  OOPS! 1 issues found!
>         kwidgetitemdelegate.h: 117 (1)

Same problem, our beloved bot couldn't find 'type' anywhere.

> 4. Check for methods that are undeclared or undefined...  OOPS! 9 issues
> found!
>         kwidgetitemdelegate.cpp: 62, 70, 154, 167, 176, 225, 260 (7)
>         kwidgetitemdelegatepool.cpp: 60, 70 (2)
>
> 7. Check for mismatched class members...  OOPS! 2 issues found!
>         kwidgetitemdelegate.cpp: 58 (1)
>         kwidgetitemdelegatepool.cpp: 56 (1)

Are those important ? I mean, they belong to the internal implementation.


Regards,
Rafael Fernández López.

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]