From kde-core-devel Wed May 07 01:16:32 2008 From: Rafael =?iso-8859-1?q?Fern=E1ndez_L=F3pez?= Date: Wed, 07 May 2008 01:16:32 +0000 To: kde-core-devel Subject: Re: Goya in kdereview Message-Id: <200805070316.33194.ereslibre () kde ! org> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=121012314412730 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--nextPart3102955.pDu9LJsyrq" --nextPart3102955.pDu9LJsyrq Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Hi, Thanks for your checks Allen. I will tomorrow commit the Mainpage.dox. > 1. Check for undocumented methods... OOPS! 8 issues found! > kwidgetitemdelegate.h: 117, 138 (2) > kwidgetitemdelegatepool.cpp: 44, 46,47, 49, 50, 51 (6) I can't find any method on kwidgetitemdelegate.h: 117 or 138. 117 is the=20 beginning of a multi-line comment, and 138 is the d-pointer declaration. > 2. Check for undocumented parameters... OOPS! 1 issues found! > kwidgetitemdelegate.h: 128 (1) Yeah, small one, it was written 'type' instead of 'types'. Thanks for that= =20 one. > 3. Check for unknown parameters... OOPS! 1 issues found! > kwidgetitemdelegate.h: 117 (1) Same problem, our beloved bot couldn't find 'type' anywhere. > 4. Check for methods that are undeclared or undefined... OOPS! 9 issues > found! > kwidgetitemdelegate.cpp: 62, 70, 154, 167, 176, 225, 260 (7) > kwidgetitemdelegatepool.cpp: 60, 70 (2) > > 7. Check for mismatched class members... OOPS! 2 issues found! > kwidgetitemdelegate.cpp: 58 (1) > kwidgetitemdelegatepool.cpp: 56 (1) Are those important ? I mean, they belong to the internal implementation. Regards, Rafael Fern=E1ndez L=F3pez. --nextPart3102955.pDu9LJsyrq Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQBIIQLxck5Abj8B0HARAtzSAKDzHay0E+utPPlks6gtesCBUAB74wCgp170 5ttyBhefpVV+n24UxALMLZg= =iTjA -----END PGP SIGNATURE----- --nextPart3102955.pDu9LJsyrq--