[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [Patch] KMainWindow::saveMainWindowSettings not saving toolbar in
From:       David Faure <faure () kde ! org>
Date:       2008-04-11 8:28:26
Message-ID: 200804111028.27480.faure () kde ! org
[Download RAW message or body]

On Friday 11 April 2008, Oswald Buddenhagen wrote:
> On Fri, Apr 11, 2008 at 01:18:21AM +0200, Eduardo Robles Elvira wrote:
> > It might break some user settings from kde 4.0 and I'm sorry for that
> > =), but that doesn't mean it's not a bug.
> > If I give a KConfigGroup to saveMainWindowSettings, it's because I
> > want to store the settings in the group.
> >
> indeed.
> 
> the apidoc also clearly backs up eduardo's standpoint.

OK, objection withdrawn.

Don't backport, though. You don't need it in the branch, and there's no reason to lose
settings when upgrading a 4.0.x patch-level release.

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
[prev in list] [next in list] [prev in thread] [next in thread]