[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [Patch] KMainWindow::saveMainWindowSettings not saving toolbar
From:       Oswald Buddenhagen <ossi () kde ! org>
Date:       2008-04-11 6:27:16
Message-ID: 20080411062716.GA22919 () ugly ! local
[Download RAW message or body]

On Fri, Apr 11, 2008 at 01:18:21AM +0200, Eduardo Robles Elvira wrote:
> It might break some user settings from kde 4.0 and I'm sorry for that
> =), but that doesn't mean it's not a bug.
> If I give a KConfigGroup to saveMainWindowSettings, it's because I
> want to store the settings in the group.
>
indeed.

the apidoc also clearly backs up eduardo's standpoint.

> Maybe in kde3 it was meant to work like this.. but then if groups
> didn't exist then this function would take a non existant config group
> as an argument. When the function' signature was changed to take a
> config group as a parameter, then the expected behaviour of the
> function changed. I.e. if I wanted to store them in a config file, I
> would give it a config file =).
> 
yes. this api change was unfortunately done without much attention in a
big "make kconfiggroup more popular in the api" effort.

-- 
Hi! I'm a .signature virus! Copy me into your ~/.signature, please!
--
Confusion, chaos, panic - my work here is done.
[prev in list] [next in list] [prev in thread] [next in thread]