[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] KFilePlacesModel : separate storage for custom items
From:       nf2 <nf2 () scheinwelt ! at>
Date:       2008-03-28 2:35:32
Message-ID: 47EC5974.3010902 () scheinwelt ! at
[Download RAW message or body]

Kevin Ottens wrote:
> Le Thursday 27 March 2008, nf2 a écrit :
>   
>> That's intentional. They have to be a 1:1copy (otherwise my comparator
>> won't work and we might run into an endless synchronization ping pong).
>> According to the xbel spec it's perfectly ok to have such private
>> metadata (that's the whole point of the owner= attribute):
>>     
>
> Hmmm, then I forgot to test something, adding something in the shortcuts.xbel 
> file directly and see how the synchronization cope with that (it won't have 
> an ID for a start).
>
>   

The missing id should be created in such cases.

>   
>>> Testing your patch I noticed that now the default places have wrong
>>> icons... Actually after reverting I still see this behavior, so I wonder
>>> if it could be related to your previous changes to KBookmark.
>>>       

Yeah - you were right - a stupid "last minute" change in my KBookmark 
patch caused this problem. I just committed a fix.

So please update, "rm .kde4/share/apps/kfileplaces/bookmarks.xml" and 
try again...

Cheers,
Norbert


[prev in list] [next in list] [prev in thread] [next in thread]