[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] KFilePlacesModel : separate storage for custom items
From:       Kevin Ottens <ervin () kde ! org>
Date:       2008-03-27 10:22:48
Message-ID: 200803271122.59774.ervin () kde ! org
[Download RAW message or body]


Le Thursday 27 March 2008, nf2 a écrit :
> That's intentional. They have to be a 1:1copy (otherwise my comparator
> won't work and we might run into an endless synchronization ping pong).
> According to the xbel spec it's perfectly ok to have such private
> metadata (that's the whole point of the owner= attribute):

Hmmm, then I forgot to test something, adding something in the shortcuts.xbel 
file directly and see how the synchronization cope with that (it won't have 
an ID for a start).

> But of course only the custom items (not isSystemItem=true) should be
> synchronized (no home, /, remote:, trash: should appear in the
> shortcuts.xbel).

Right, my mistake, I really had more "ID" in mind.

> > Testing your patch I noticed that now the default places have wrong
> > icons... Actually after reverting I still see this behavior, so I wonder
> > if it could be related to your previous changes to KBookmark.
>
> Could be. I got some migration code for the icons, but who knows. Here
> it works, but of course i have deleted the bookmark files, so
> KFilePlacesModel re-created the default places.

Well, that's what I did, I started over with a clean kfileplaces to let it 
recreate...

Regards.
-- 
Kévin 'ervin' Ottens, http://ervin.ipsquad.net
"Ni le maître sans disciple, Ni le disciple sans maître,
Ne font reculer l'ignorance."

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]