[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] Solid circular deletion
From:       Kevin Ottens <ervin () kde ! org>
Date:       2008-02-19 7:27:46
Message-ID: 200802190827.51518.ervin () kde ! org
[Download RAW message or body]


Le Tuesday 19 February 2008, Alex Merry a écrit :
> On Tuesday 19 February 2008 01:21:24 Alex Merry wrote:
> > The attached patch seems to fix it, but I'm not sure if it's really the
> > correc t fix - can someone who knows about the code (or using
> > QExplicitlySharedPointe r as a self reference) check it?  It may
> > introduce memory leaks.
>
> Actually, I'm pretty certain that's not the correct fix.  I've discovered
> that the patch causes crashes when quitting any application that uses
> Solid.

I strongly advise you to write a unit test that show this behavior. And then 
we can work on a proper fix. I have unit tests for device unplugging already, 
and they don't show up this problem, so they probably need to be completed to 
catch your case.

Regards.
-- 
Kévin 'ervin' Ottens, http://ervin.ipsquad.net
"Ni le maître sans disciple, Ni le disciple sans maître,
Ne font reculer l'ignorance."

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]