From kde-core-devel  Tue Feb 19 07:27:46 2008
From: Kevin Ottens <ervin () kde ! org>
Date: Tue, 19 Feb 2008 07:27:46 +0000
To: kde-core-devel
Subject: Re: [PATCH] Solid circular deletion
Message-Id: <200802190827.51518.ervin () kde ! org>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=120340610432590
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--nextPart2152205.pEsChKvMco"

--nextPart2152205.pEsChKvMco
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Le Tuesday 19 February 2008, Alex Merry a =C3=A9crit :
> On Tuesday 19 February 2008 01:21:24 Alex Merry wrote:
> > The attached patch seems to fix it, but I'm not sure if it's really the
> > correc t fix - can someone who knows about the code (or using
> > QExplicitlySharedPointe r as a self reference) check it?  It may
> > introduce memory leaks.
>
> Actually, I'm pretty certain that's not the correct fix.  I've discovered
> that the patch causes crashes when quitting any application that uses
> Solid.

I strongly advise you to write a unit test that show this behavior. And the=
n=20
we can work on a proper fix. I have unit tests for device unplugging alread=
y,=20
and they don't show up this problem, so they probably need to be completed =
to=20
catch your case.

Regards.
=2D-=20
K=C3=A9vin 'ervin' Ottens, http://ervin.ipsquad.net
"Ni le ma=C3=AEtre sans disciple, Ni le disciple sans ma=C3=AEtre,
Ne font reculer l'ignorance."

--nextPart2152205.pEsChKvMco
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4-svn0 (GNU/Linux)

iD8DBQBHuoT3B0u7y43syeIRAm7IAKCdb7mjjIump0Ac1AG/AQsS5QQrKACgn577
DozoQxzsa2s4hPovK9kBLUA=
=NbWk
-----END PGP SIGNATURE-----

--nextPart2152205.pEsChKvMco--