[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] Fixes meinproc/docbook can't handle paths with spaces
From:       Ingo =?iso-8859-1?q?Kl=F6cker?= <kloecker () kde ! org>
Date:       2007-12-21 0:06:26
Message-ID: 200712210106.32901 () erwin ! ingo-kloecker ! de
[Download RAW message or body]


On Thursday 20 December 2007, Alexander Neundorf wrote:
> On Thursday 20 December 2007, Ingo Klöcker wrote:
> > On Thursday 20 December 2007, Alexander Neundorf wrote:
> > > On Wednesday 19 December 2007, Ingo Klöcker wrote:
> > > > On Tuesday 18 December 2007, Alexander Neundorf wrote:
> > > > > On Tuesday 18 December 2007, Ingo Klöcker wrote:
> > > > > > FWIW, below you'll find the function that parses the result
> > > > > > of getenv("SGML_CATALOG_FILES"). The code is pretty
> > > > > > straightforward and it's obvious that nobody thought about
> > > > > > spaces in a catalog's path.
> > > > >
> > > > > Can you file a bug report for libxml ?
> > > >
> > > > Instead of doing this I have converted the SGML catalogs in
> > > > kdoctools to XML catalogs and made meinproc write the catalog
> > > > paths (encoded as file URLs) to the environment variable
> > > > XML_CATALOG_FILES.
> > > >
> > > > Now kdelibs builds even if the source dir contains spaces.
> > > >
> > > > Is it okay to commit this patch and to svn add the new XML
> > > > catalogs (see attached tar ball)?
> > >
> > > I can't comment on that.
> > > IMO it is a bug fix, not a feature.
> >
> > Does the patch work for you?
>
> The build worked now, but I still got warnings:
>
> [ 65%] Generating kde4-config.1
> /home/alex/src/kde4-svn/KDE
> dir/kdelibs/doc/kde4-config/man-kde4-config.1.docbook:4: I/O warning
> : failed to load external entity "dtd/kdex.dtd"
> ]>
>   ^
> /home/alex/src/kde4-svn/KDE
> dir/kdelibs/doc/kde4-config/man-kde4-config.1.docbook:6: parser error
> : Entity 'language' not defined
> <refentry lang="&language;">
>                           ^

Okay. xslt.cpp in kdoctools also needs to be changed. Unfortunately, the 
simple xmlLoadCatalogs() call cannot be replaced by an equally simple 
alternative call to load the XML catalogs instead of the SGML catalogs. 
*sigh* So this will take some more time. Probably till after xmas.


Regards,
Ingo

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]