From kde-core-devel Fri Dec 21 00:06:26 2007 From: Ingo =?iso-8859-1?q?Kl=F6cker?= Date: Fri, 21 Dec 2007 00:06:26 +0000 To: kde-core-devel Subject: Re: [PATCH] Fixes meinproc/docbook can't handle paths with spaces Message-Id: <200712210106.32901 () erwin ! ingo-kloecker ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=119819577600302 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--nextPart3481815.txF98sFSX2" --nextPart3481815.txF98sFSX2 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Thursday 20 December 2007, Alexander Neundorf wrote: > On Thursday 20 December 2007, Ingo Kl=F6cker wrote: > > On Thursday 20 December 2007, Alexander Neundorf wrote: > > > On Wednesday 19 December 2007, Ingo Kl=F6cker wrote: > > > > On Tuesday 18 December 2007, Alexander Neundorf wrote: > > > > > On Tuesday 18 December 2007, Ingo Kl=F6cker wrote: > > > > > > FWIW, below you'll find the function that parses the result > > > > > > of getenv("SGML_CATALOG_FILES"). The code is pretty > > > > > > straightforward and it's obvious that nobody thought about > > > > > > spaces in a catalog's path. > > > > > > > > > > Can you file a bug report for libxml ? > > > > > > > > Instead of doing this I have converted the SGML catalogs in > > > > kdoctools to XML catalogs and made meinproc write the catalog > > > > paths (encoded as file URLs) to the environment variable > > > > XML_CATALOG_FILES. > > > > > > > > Now kdelibs builds even if the source dir contains spaces. > > > > > > > > Is it okay to commit this patch and to svn add the new XML > > > > catalogs (see attached tar ball)? > > > > > > I can't comment on that. > > > IMO it is a bug fix, not a feature. > > > > Does the patch work for you? > > The build worked now, but I still got warnings: > > [ 65%] Generating kde4-config.1 > /home/alex/src/kde4-svn/KDE > dir/kdelibs/doc/kde4-config/man-kde4-config.1.docbook:4: I/O warning > : failed to load external entity "dtd/kdex.dtd" > ]> > ^ > /home/alex/src/kde4-svn/KDE > dir/kdelibs/doc/kde4-config/man-kde4-config.1.docbook:6: parser error > : Entity 'language' not defined > > ^ Okay. xslt.cpp in kdoctools also needs to be changed. Unfortunately, the=20 simple xmlLoadCatalogs() call cannot be replaced by an equally simple=20 alternative call to load the XML catalogs instead of the SGML catalogs.=20 *sigh* So this will take some more time. Probably till after xmas. Regards, Ingo --nextPart3481815.txF98sFSX2 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4-svn0 (GNU/Linux) iD8DBQBHawOIGnR+RTDgudgRAi24AKDRQlze+Yj+DCyKTRSqe/U/+aH29QCghHr3 bZOJcK11i2qxu7akrXX9MYk= =f8uv -----END PGP SIGNATURE----- --nextPart3481815.txF98sFSX2--