[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH]KConfigGroup::groupList() kind of broken
From:       David Faure <faure () kde ! org>
Date:       2007-11-19 22:48:14
Message-ID: 200711192348.14589.faure () kde ! org
[Download RAW message or body]

On Monday 19 November 2007, Andreas Pakulat wrote:
> > - does kconfiggroup::keyList() behave as it should (i.e., not including
> >   keys from subgroups)?
> 
> Test added to kconfigtest, shows that keyList() behaves as it should.

Minor comments about the unit test:
* Thanks for writing them :)
* QVERIFY(subcg3.readEntry( "sub3string", "") == QString("somevalue") );
should be QCOMPARE(subcg3.readEntry( "sub3string", ""), QString("somevalue") );
so that in case of failure you see the expected value and the actual value.
Works for the QStringLists too (well, the output of non-matching qstringlists will
be better in the next Qt release, I reported & fixed a bug there).

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).

[prev in list] [next in list] [prev in thread] [next in thread]