[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    need BIC and SIC change to phonon
From:       Matthias Kretz <kretz () kde ! org>
Date:       2007-11-16 12:40:42
Message-ID: 200711161340.48797.kretz () kde ! org
[Download RAW message or body]


Hi,

I need to fix an interface class for the phonon backends:
VolumeFaderInterface has a slightly different function signature as does 
EffectInterface. As backend implementations for VolumeFaderInterface have to 
inherit EffectInterface anyway, the two functions need to simply be removed 
from the VolumeFaderInterface.

--- volumefaderinterface.h      (revision 737258)
+++ volumefaderinterface.h      (working copy)
@@ -37,12 +37,9 @@
         }
         virtual void setFadeCurve(Phonon::VolumeFaderEffect::FadeCurve) {}
         virtual void fadeTo(float, int) {}
-        virtual QVariant parameterValue(int) const { return QVariant(); }
-        virtual void setParameterValue(int, const QVariant &) {}
-
 };
 }

-Q_DECLARE_INTERFACE(Phonon::VolumeFaderInterface, "VolumeFaderInterface3.phonon.kde.org")
+Q_DECLARE_INTERFACE(Phonon::VolumeFaderInterface, "VolumeFaderInterface4.phonon.kde.org")

 #endif // PHONON_VOLUMEFADERINTERFACE_H


PS: I only found this error because I added -Woverloaded-virtual to my 
CXXFLAGS.

-- 
________________________________________________________
Matthias Kretz (Germany)                            <><
http://Vir.homelinux.org/
MatthiasKretz@gmx.net, kretz@kde.org,
Matthias.Kretz@urz.uni-heidelberg.de

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]