From kde-core-devel  Fri Nov 16 12:40:42 2007
From: Matthias Kretz <kretz () kde ! org>
Date: Fri, 16 Nov 2007 12:40:42 +0000
To: kde-core-devel
Subject: need BIC and SIC change to phonon
Message-Id: <200711161340.48797.kretz () kde ! org>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=119521690020572
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--nextPart5752507.inifCRkit7"

--nextPart5752507.inifCRkit7
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Hi,

I need to fix an interface class for the phonon backends:
VolumeFaderInterface has a slightly different function signature as does=20
EffectInterface. As backend implementations for VolumeFaderInterface have t=
o=20
inherit EffectInterface anyway, the two functions need to simply be removed=
=20
from the VolumeFaderInterface.

=2D-- volumefaderinterface.h      (revision 737258)
+++ volumefaderinterface.h      (working copy)
@@ -37,12 +37,9 @@
         }
         virtual void setFadeCurve(Phonon::VolumeFaderEffect::FadeCurve) {}
         virtual void fadeTo(float, int) {}
=2D        virtual QVariant parameterValue(int) const { return QVariant(); }
=2D        virtual void setParameterValue(int, const QVariant &) {}
=2D
 };
 }

=2DQ_DECLARE_INTERFACE(Phonon::VolumeFaderInterface, "VolumeFaderInterface3=
=2Ephonon.kde.org")
+Q_DECLARE_INTERFACE(Phonon::VolumeFaderInterface, "VolumeFaderInterface4.p=
honon.kde.org")

 #endif // PHONON_VOLUMEFADERINTERFACE_H


PS: I only found this error because I added -Woverloaded-virtual to my=20
CXXFLAGS.

=2D-=20
________________________________________________________
Matthias Kretz (Germany)                            <><
http://Vir.homelinux.org/
MatthiasKretz@gmx.net, kretz@kde.org,
Matthias.Kretz@urz.uni-heidelberg.de

--nextPart5752507.inifCRkit7
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQBHPY/Qyg4WnCj6OIoRAm9AAJ0bRUDf3wsx8+vrHQtry8Uq1M09fACeLRjS
NUmuBdsJ2ay2htv9pSdeH9c=
=W6eE
-----END PGP SIGNATURE-----

--nextPart5752507.inifCRkit7--