[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [patch] Grab windows anywhere, not just titlebar
From:       "Dan Meltzer" <parallelgrapefruit () gmail ! com>
Date:       2007-11-07 17:37:13
Message-ID: 46059ce10711070937v7f4c6cf0g9db49e23a0fa546a () mail ! gmail ! com
[Download RAW message or body]

On 11/7/07, Stefan Monov <logixoul@gmail.com> wrote:
> Hi,
>
> So I saw Frederik's commit 731583:
> "Make it possible to move the krunner window by clicking on an empty part
> of it and dragging the mouse."
>
> I have always thought it would be great if all KDE windows behaved like that
> (btw Mac OS X does it), so I did some copy-paste-fu and here we have a
> patch -- attached.
>
> It makes all KMainWindows and KDialogs grabable. cool =)

Hi,

While this is a cool change, I feel that it is

A) Not a bugfix.  At this point kdelibs is in bugfix only mode afaik,
and therefore this should be postponed.

B) Not Portable.  This uses x11 specific stuff, KMainWindow needs to
be usable on both Mac and windows (Not a problem for plasma as it is
only runnable on X11).  Therefore this would at a minimum need to be
ifdeffed (ugly) or a more portable way of doing it would need to be
found.

Dan,
>
> Unfortunately it doesn't work when you grab:
> - the space on the right of menubars
> - a groupbox
> - a widgetstack
> - the space on the right of breadcrumb bars
> - etc.
>
> Inherent disadvantages:
> - introduces inconsistency with non-kde apps
> - anything else?
>
> Would be nice if the code was shared instead of copy-pasted.
>
> It will also let us do away with the titlebar bevel in Oxygen, which we
> introduced to make it clear where the grabable titlebar ends (though it
> clashes badly with the artistic vision).
>
> Comments? Improvements?
> How to make it work on menubars?
> Too late for such a big change in 4.0?
> Compatibility with other WMs, OSes?
>
> Cheers,
> Stefan
>
> ps: hmm, looks like a dot commenter had the same idea ;)
>
>
[prev in list] [next in list] [prev in thread] [next in thread]