[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: [PATCH/RFC] KMultiTabBar surgery...
From: "Joris Guisson" <joris.guisson () gmail ! com>
Date: 2007-10-01 17:15:41
Message-ID: 6bc528f40710011015w39a49073ldcd78546c603263e () mail ! gmail ! com
[Download RAW message or body]
OK, patch is fine for me, I must say it looks a lot better then before with
oxygen as style.
Joris,
On 10/1/07, Joris Guisson <joris.guisson@gmail.com> wrote:
>
> Seeing that KTorrent also uses KMultiTabBar, I would like to test this
> before you commit. I will do this, this evening when I get back from work.
> Don't know how late that is in your timezone, but I believe the US is 6
> hours or more behind Europe, so you should have an answer in time.
>
> I hope this patch solves the rendering issues with oxygen, because a
> selected tab is rendered very ugly with oxygen.
>
> Joris,
>
> On 10/1/07, Christoph Cullmann <cullmann@absint.com> wrote:
> >
> > On Monday 01 October 2007 06:12, Maksim Orlovich wrote:
> > > Hi... When looking at fixing major problems in painting of konq's
> > sidebar
> > > in trunk (#148192, perhaps others), I quickly diagnosed it to
> > KMultiTabBar
> > > widget in kdeui, which is also used in Kate. Unfortunately, it's
> > currently
> > > in a rather bad state --- it has tons of methods that don't do
> > anything,
> > > unused modes that do weird things, etc. Worse, its basic operation
> > mode is
> > > to hard code width to 24 pixels. This of course is very wrong since
> > > accessibility may require a larger font (plus it has its own,
> > > ultra-complex layout code). In short, the attached removes most of
> > these
> > > things. Most of the interesting work now is done by Qt layouts, and
> > the
> > > toggle-tab widgets provide appropriate size hint and painting. One
> > cost of
> > > this change is that when widgets do not fit, it no longer goes into a
> > > multi-line mode --- but it can squeeze the label text instead. In my
> > > experience it worked well for kate w/all the plugins I have enabled.
> > API
> > > changes are just removing redundancy, unused methods of dubious values
> > and
> > > methods that did not do anything. Porting patches attached.
> > >
> > > Anyway, I will commit this monday night EST if no one has a big issue
> > with
> > > it -- but I'd welcome feedback, especially from the Kate folks in case
> > the
> > > details aren't quite to their taste.
> > I am all for it :=) KMultiTabBar is the "worst" part of the Kate UI, I
> > mostly
> > chosen it, as it allows multiple tabs to be selected at once, which is
> > needed. I doubt Kate uses the "multiple rows of text" wrapping and any
> > improvement is welcome to rendering. I have not tested the patches for
> > the
> > look'n'feel, but if you say it looks well, I trust you. (given the
> > current
> > state, I doubt there can be any worse look possible...)
> >
> > cu
> > Christoph
> >
> > --
> > -------------------------------------- Christoph Cullmann ---------
> > AbsInt Angewandte Informatik GmbH Email: cullmann@AbsInt.com
> > Science Park 1 Tel: +49-681-38360-22
> > 66123 Saarbrücken Fax: +49-681-38360-20
> > GERMANY WWW: http://www.AbsInt.com
> > --------------------------------------------------------------------
> > Geschäftsführung: Dr.-Ing. Christian Ferdinand
> > Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234
> >
>
>
[Attachment #3 (text/html)]
OK, patch is fine for me, I must say it looks a lot better then before with oxygen as \
style.<br><br>Joris,<br><br><div><span class="gmail_quote">On 10/1/07, <b \
class="gmail_sendername">Joris Guisson</b> <<a \
href="mailto:joris.guisson@gmail.com"> joris.guisson@gmail.com</a>> \
wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, \
204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Seeing that KTorrent also \
uses KMultiTabBar, I would like to test this before you commit. I will do this, this \
evening when I get back from work. Don't know how late that is in your timezone, \
but I believe the US is 6 hours or more behind Europe, so you should have an answer \
in time. <br><br>I hope this patch solves the rendering issues with oxygen, because a \
selected tab is rendered very ugly with oxygen.<br><span \
class="sg"><br>Joris,</span><div><span class="e" \
id="q_1155aca573180706_2"><br><br><div> <span class="gmail_quote">On 10/1/07, <b \
class="gmail_sendername">Christoph Cullmann </b> <<a \
href="mailto:cullmann@absint.com" target="_blank" onclick="return \
top.js.OpenExtLink(window,event,this)">cullmann@absint.com</a>> \
wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, \
204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> On Monday 01 October 2007 \
06:12, Maksim Orlovich wrote: <br>> Hi... When looking at fixing major problems in \
painting of konq's sidebar<br>> in trunk (#148192, perhaps others), I quickly \
diagnosed it to KMultiTabBar<br>> widget in kdeui, which is also used in Kate. \
Unfortunately, it's currently <br>> in a rather bad state --- it has tons of \
methods that don't do anything,<br>> unused modes that do weird things, etc. \
Worse, its basic operation mode is<br>> to hard code width to 24 pixels. This of \
course is very wrong since <br>> accessibility may require a larger font (plus it \
has its own,<br>> ultra-complex layout code). In short, the attached removes most \
of these<br>> things. Most of the interesting work now is done by Qt layouts, and \
the <br>> toggle-tab widgets provide appropriate size hint and painting. One cost \
of<br>> this change is that when widgets do not fit, it no longer goes into \
a<br>> multi-line mode --- but it can squeeze the label text instead. In my \
<br>> experience it worked well for kate w/all the plugins I have enabled. \
API<br>> changes are just removing redundancy, unused methods of dubious values \
and<br>> methods that did not do anything. Porting patches attached. \
<br>><br>> Anyway, I will commit this monday night EST if no one has a big \
issue with<br>> it -- but I'd welcome feedback, especially from the Kate folks \
in case the<br>> details aren't quite to their taste. <br>I am all for it :=) \
KMultiTabBar is the "worst" part of the Kate UI, I mostly<br>chosen it, as \
it allows multiple tabs to be selected at once, which is<br>needed. I doubt Kate uses \
the "multiple rows of text" wrapping and any <br>improvement is welcome to \
rendering. I have not tested the patches for the<br>look'n'feel, but if you \
say it looks well, I trust you. (given the current<br>state, I doubt there can be any \
worse look possible...) \
<br><br>cu<br>Christoph<br><br>--<br>-------------------------------------- Christoph \
Cullmann ---------<br>AbsInt Angewandte Informatik \
GmbH Email: <a href="mailto:cullmann@AbsInt.com" \
target="_blank" onclick="return top.js.OpenExtLink(window,event,this)"> \
cullmann@AbsInt.com</a><br>Science Park \
1 \
Tel: +49-681-38360-22 <br>66123 \
Saarbrücken Fax: \
+49-681-38360-20<br>GERMANY   \
; WWW: \
<a href="http://www.AbsInt.com" target="_blank" onclick="return \
top.js.OpenExtLink(window,event,this)">http://www.AbsInt.com \
</a><br>-------------------------------------------------------------------- \
<br>Geschäftsführung: Dr.-Ing. Christian Ferdinand<br>Eingetragen im Handelsregister \
des Amtsgerichts Saarbrücken, HRB 11234<br></blockquote></div><br> \
</span></div></blockquote></div><br>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic